Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesktopFileManager::resolve_app_id should not return an app id with a .desktop file suffix #3608

Closed
mattkae opened this issue Sep 24, 2024 · 0 comments · Fixed by #3629
Closed
Assignees
Labels
triaged Triage into JIRA to plan it in

Comments

@mattkae
Copy link
Contributor

mattkae commented Sep 24, 2024

Problem

The app_id that is returned by ForeignTopLevelManagerV1 typically ends with a .desktop suffix as it currently stands. We did this originally because g_app_info_get_id typically returns the app id this way, although it doesn't have to. In cases where the app id is not found with g_app_info_get_id, we were appending .desktop. We shouldn't do this, as this isn't necessarily correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Triage into JIRA to plan it in
Projects
None yet
1 participant