execvpe isn't officially async-signal-safe!

canonical · Sep 11, 2024 · 71542db · 71542db
1 parent cb8a9fe
commit 71542db
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/miral/launch_app.cpp b/src/miral/launch_app.cpp
@@ -155,6 +155,7 @@ auto miral::launch_app_env(
         sigfillset(&all_signals);
         pthread_sigmask(SIG_UNBLOCK, &all_signals, nullptr);
 
+        // execvpe() isn't listed as being async-signal-safe, but the implementation looks fine and rewriting seems unnecessary
         execvpe(exec_args[0], const_cast<char*const*>(exec_args.data()), const_cast<char*const*>(exec_env.data()));
 
         mir::log_warning("Failed to execute client (\"%s\") error: %s", exec_args[0], strerror(errno));