inotify_init1(IN_CLOEXEC) (#3550)

As [mentioned](#3544 (comment)) by @RAOF, we don't want the FD leaking to child processes
canonical · Aug 14, 2024 · 6344c95 · 6344c95
2 parents 210d4c4 + 1ce7b6d
commit 6344c95
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/miral/static_display_config.cpp b/src/miral/static_display_config.cpp
@@ -627,7 +627,7 @@ auto miral::ReloadingYamlFileDisplayConfig::inotify_config_path() -> std::option
 
     if (!config_path_) return std::nullopt;
 
-    mir::Fd inotify_fd{inotify_init()};
+    mir::Fd inotify_fd{inotify_init1(IN_CLOEXEC)};
 
     if (inotify_fd < 0)
         BOOST_THROW_EXCEPTION((std::system_error{errno, std::system_category(), "Failed to initialize inotify_fd"}));

diff --git a/src/server/frontend_wayland/foreign_toplevel_manager_v1.cpp b/src/server/frontend_wayland/foreign_toplevel_manager_v1.cpp
@@ -501,7 +501,7 @@ void mf::ForeignSurfaceObserver::application_id_set_to(
 // GDesktopFileCache
 mf::GDesktopFileCache::GDesktopFileCache(const std::shared_ptr<MainLoop> &main_loop)
     : main_loop{main_loop},
-      inotify_fd{inotify_init()}
+      inotify_fd{inotify_init1(IN_CLOEXEC)}
 {
     refresh_app_cache();