Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bail on error in dependency installation #80

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Feb 8, 2024

Fixes #79

@Saviq Saviq requested a review from hbatagelo February 8, 2024 17:23
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e217e4c) 64.44% compared to head (4a9dc52) 64.05%.
Report is 1 commits behind head on main.

Files Patch % Lines
mir-ci/mir_ci/conftest.py 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   64.44%   64.05%   -0.39%     
==========================================
  Files          11       11              
  Lines         734      740       +6     
  Branches       91       92       +1     
==========================================
+ Hits          473      474       +1     
- Misses        237      241       +4     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bails if the deps name is incorrect, but still passes when the dependency has been installed and removed (not purged). Is that intended?

@Saviq
Copy link
Collaborator Author

Saviq commented Feb 8, 2024

@hbatagelo yeah, #77 not fixed here yet.

@Saviq Saviq enabled auto-merge February 9, 2024 06:34
@Saviq Saviq added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 20f3a84 Feb 9, 2024
13 of 14 checks passed
@Saviq Saviq deleted the fix-deps-error branch February 9, 2024 11:18
Saviq added a commit that referenced this pull request Mar 19, 2024
deps: bail on error in dependency installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed dependency install skimmed over
2 participants