Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.29] watch query timeout backport k8s-dqlite #4653

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

louiseschmidtgen
Copy link
Contributor

Description

Backports watcher query timeout in k8s-dqlite: canonical/k8s-dqlite#161

The PR adds a timeout on long running after queries in k8s-dqlite which are part of the watcher's poll loop.
The timeout is configurable using the watch-query-timeout flag.

Context

This PR addresses issues raised in microk8s where after the leader node is removed from the cluster the remaining nodes also go into NotReady state for ~20 minutes. This timeout helps the responsiveness of the cluster after loosing its leader.

@louiseschmidtgen
Copy link
Contributor Author

louiseschmidtgen commented Sep 2, 2024

Testing multi-distros fails since after the lxd separation the community images are not available anymore. Removing Centos from run.

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiseschmidtgen louiseschmidtgen merged commit 7e53d77 into 1.29 Sep 3, 2024
12 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-1434/1.29-watcher-query-timeout branch September 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants