-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve explanation of networking approach #633
doc: improve explanation of networking approach #633
Conversation
e8ec1fc
to
057ddca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great thanks, ive left a few suggestions though.
Signed-off-by: Minae Lee <[email protected]>
057ddca
to
52141e8
Compare
Thank you! Should all be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only now got a chance to thoroughly review. Approved from my side when it comes to structure, readability and context. I think it provides a good overview and clarity. For technical correctness I'll rely on the engineers to double-check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small comments.
…pages Signed-off-by: Minae Lee <[email protected]>
Signed-off-by: Minae Lee <[email protected]>
52141e8
to
c7a3e9f
Compare
…d to be unused Signed-off-by: Minae Lee <[email protected]>
c7a3e9f
to
bac4fa9
Compare
Addressed, thanks! |
This PR adds an explanation/networking page to explain MicroCloud's networking approach, including its use of OVN and a comparison to VPCs (Virtual Private Clouds).
This reduces the need for a Networking section in the About MicroCloud page. A separate commit removes most of that section, and also re-allocates most of the remaining information to a more suitable location: the Reference page on networking requirements. It also updates relevant links.