Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microcloud/version: Bump version to 1.1 #185

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

masnax
Copy link
Contributor

@masnax masnax commented Oct 11, 2023

No description provided.

@masnax masnax requested a review from tomponline as a code owner October 11, 2023 17:04
@tomponline
Copy link
Member

Where is the api version specified?

@tomponline
Copy link
Member

tomponline commented Oct 11, 2023

Please can you change commit message to:

Release MicroCloud 1.1

@masnax
Copy link
Contributor Author

masnax commented Oct 11, 2023

Where is the api version specified?

MicroCloud doesn't have much of an API, and what little there is isn't user-accessible, so there's no explicit versioning yet. There's schema versioning built into microcluster but microcloud doesn't extend it yet.

@tomponline
Copy link
Member

Where is the api version specified?

MicroCloud doesn't have much of an API, and what little there is isn't user-accessible, so there's no explicit versioning yet. There's schema versioning built into microcluster but microcloud doesn't extend it yet.

Hrm are you saying the endpoints don't start with /1.0?

@masnax
Copy link
Contributor Author

masnax commented Oct 11, 2023

Where is the api version specified?

MicroCloud doesn't have much of an API, and what little there is isn't user-accessible, so there's no explicit versioning yet. There's schema versioning built into microcluster but microcloud doesn't extend it yet.

Hrm are you saying the endpoints don't start with /1.0?

Sorry, I misunderstood you a bit. I thought you meant a record of API updates like we have with LXD that's included in GetServer.

The actual API version is defined by MicroCluster here, it's not managed by MicroCloud:
https://github.com/canonical/microcluster/blob/e3b7b60a4d71577f5d0f5460f71dbb33dfcb5d9c/internal/rest/client/client.go#L32

@tomponline tomponline merged commit 2aea340 into canonical:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants