Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CRAFT_TARGET_ARCH to set which arch to build #4

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Sep 27, 2024

Details

Discovered the arm64 images didn't run b/c although pebble was arm64, the metrics server binary wasn't

Overview

Use CRAFT_TARGET_ARCH to set the architecture for the build during the rockcraft build stage.

@addyess
Copy link
Contributor Author

addyess commented Sep 27, 2024

@canonical/kubernetes once this merges, please update the k8s-snap to use the new image from this ghcr.io

Copy link

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit a95945e into main Oct 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants