improve README #93
improve README #93
Conversation
alexsander-souza
commented
Mar 4, 2023
alexsander-souza
commented
- update to latest MAAS release (3.3)
- add instructions to install Ansible on Jammy
- add note about DB data preserved in the nodes after a teardown
alexsander-souza
force-pushed
the
improve_readme
branch
from
0f37ea4
to
365d570
Compare
| On systems running the latest Ubuntu LTS version (Jammy), run the following commands to install Ansible: | ||
|
|
||
| ``` | ||
| sudo apt-get install ansible |
There was a problem hiding this comment.
I believe this installs an older version of ansible- we can just refer people to the ansible installation documentation instead, or recommend to install via pip like ansible documentation recommends
There was a problem hiding this comment.
Do we have a strong reason to ask people to install the upstream version instead of the Ubuntu version? Do we use any feature that is not available?
There was a problem hiding this comment.
I think the lines bellow instructing the install of ansible.utils is useful, but I think it's safe to assume the user has ansible installed if they're using our playbook, and since there are so many methods to install ansible, I think it would be reasonable to specify a minimum version, but leave it to the user as to how its installed. There's also ansible-tower / AWX which makes this a bit more complicated, so best we just leave this open in my opinion.
There was a problem hiding this comment.
maybe we should move this to https://maas.io/docs/how-to-spin-up-maas-with-ansible
There was a problem hiding this comment.
I think leaving it open or directing the user to Ansible's own installation documentation should suffice
There was a problem hiding this comment.
I think it is generally not advisable to install ansible directly as a package on your system, since this usually cause a lot of issue down the line when trying to work with different ansible playbooks from different projects, which require different versions. To avoid this, i would recommend to use a virtual environment and install ansible into it. To document the needed steps, i have created the PR #122.
| @@ -166,6 +175,8 @@ ansible-playbook -i ./hosts\ | |||
| ansible-playbook -i ./hosts ./teardown.yaml | |||
| ``` | |||
|
|
|||
| > Note: this action teardowns only the services, the MAAS database is preserved in the `maas_postgres_*` nodes. You must remove these files manually before attempting to redeploy the stack. | |||
There was a problem hiding this comment.
This is an issue with teardown that I was not aware of, by itself teardown is meant to restore the nodes to pre-install state. I think we should fix teardown (which needs updating anyway, with new changes to the playbooks) rather than tell people to do manual removal alongside running teardown?
There was a problem hiding this comment.
IMO this is an interesting feature as is (I don't like dropping databases without getting multiple confirmations first). What we need is a flag purge_db (or something like this) that the user needs to explicitly set if he wants to delete data files.
|
jenkins: !test |
SK1Y101
added
WIP
- update to latest MAAS release (3.3) - add instructions to install Ansible on Jammy - add note about DB data preserved in the nodes after a teardown
