Network: Generate OVN PTR records for instance NIC IPs #14956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
force-pushed
the
tp-ovn-ptr
branch
10 times, most recently
from
e03475f to
c2a4e5f
Compare
|
FYI @fnordahl |
simondeziel
previously approved these changes
Feb 11, 2025
To make available to other packages and to avoid duplicate constant definitions for PTR suffixes. Signed-off-by: Thomas Parrott <[email protected]>
And use dnsutil.IsReverse function. Signed-off-by: Thomas Parrott <[email protected]>
…IC IPs Fixes canonical#1481 Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-ovn-ptr
branch
from
c2a4e5f to
7ef4b6e
Compare
simondeziel
approved these changes
Feb 11, 2025
|
@roosterfish @simondeziel re https://github.com/canonical/lxd/actions/runs/13271508119/job/37052332137?pr=14956 do we need to call the "waitready" equivalent command for micro* apps here? |
I'm not aware of any |
tomponline
added a commit
that referenced
this pull request
Feb 12, 2025
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Feb 12, 2025
From - canonical/lxd#14956 - canonical/lxd#14904 - canonical/lxd#14964 Signed-off-by: Thomas Parrott <[email protected]>
tomponline
added a commit
to canonical/lxd-pkg-snap
that referenced
this pull request
Feb 12, 2025
tomponline
added a commit
to tomponline/lxd
that referenced
this pull request
Feb 13, 2025
…s field that contains PTR records Fixes bug introduced with canonical#14956 Signed-off-by: Thomas Parrott <[email protected]>
tomponline
added a commit
to tomponline/lxd
that referenced
this pull request
Feb 13, 2025
…s field that contains PTR records Fixes bug introduced with canonical#14956 Signed-off-by: Thomas Parrott <[email protected]>
tomponline
added a commit
that referenced
this pull request
Feb 14, 2025
…eld that contains PTR records (#14978) Fixes bug introduced with #14956 that caused instance port SNAT rules to not be cleaned up, as LXD parses the port's DNS records to get the IPs to remove. ``` ==> Check NAT rules got cleaned up ++ ovn-nbctl --bare --format=csv --column=external_ip,logical_ip,type find nat + out='10.10.10.200,10.91.99.0/24,snat 198.51.100.2,198.51.100.2,dnat_and_snat fd42:4242:4242:1010::200,2001:db8:1:2::/64,snat' ++ wc -l + natRulesAfter=3 + '[' 2 -ne 3 ']' + echo 'NAT rules left over. Started with 2 now have 3' NAT rules left over. Started with 2 now have 3 ``` https://github.com/canonical/lxd-ci/actions/runs/13301968521/job/37144917599
tomponline
added a commit
to tomponline/lxd
that referenced
this pull request
Feb 14, 2025
…s field that contains PTR records Fixes bug introduced with canonical#14956 Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit f419130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14812
Before
After