Storage: Powerflex use Connect and Disconnect for NVMe/TCP
#14900
Conversation
roosterfish
force-pushed
the
powerflex_connect
branch
from
e9ca332 to
3d3ea60
Compare
| @@ -858,6 +858,11 @@ func (d *powerflex) deleteNVMeHost() error { | |||
| return client.deleteHost(host.ID) | |||
| } | |||
|
|
|||
| // targetQN returns the unique NQN of the target SDTs using PowerFlex's system ID. | |||
| func (d *powerflex) targetQN(systemID string) string { | |||
| return fmt.Sprintf("nqn.1988-11.com.dell:powerflex:00:%s", systemID) | |||
There was a problem hiding this comment.
I guess the nqn prefix is the same for all PF system, just wanted to point out if we are sure this is true? Because if the prefix does not match, the connection will fail.
There was a problem hiding this comment.
Had the same thoughts. Unfortunately this string doesn't seem to be returned by any PowerFlex API. I tried querying the relevant ones with no luck.
Also all the online examples always use nqn.1988-11.com.dell:powerflex:00: so I suspect this to be the same every time.
There was a problem hiding this comment.
IIRC in case of pure you get it straight from the API right?
There was a problem hiding this comment.
IIRC in case of pure you get it straight from the API right?
Yes.
Unfortunately this string doesn't seem to be returned by any PowerFlex API. I tried querying the relevant ones with no luck.
I think the prefix should be the same on all PF arrays, as the prefix is constructed as:
<protocol>.<year_of_company_creation?>.<domain_in_reverse>:<system_id>
Just not sure if this is really a standard, or if it can vary for unknown reasons
There was a problem hiding this comment.
An alternative would be to keep ConnectAll to make use of the discovery. This way we don't need to craft the target's nqn as we get it from NVMe discovery.
But then ConnectAll should support multiple addresses, the same as Connect in case one of them is down.
And Disconnect already supports just providing a string that is contained in any of the current session so in case of PowerFlex we can just pass the system id.
roosterfish
force-pushed
the
powerflex_connect
branch
from
3d3ea60 to
317049f
Compare
roosterfish
force-pushed
the
powerflex_connect
branch
from
317049f to
c46f72f
Compare
roosterfish
force-pushed
the
powerflex_connect
branch
from
c46f72f to
554c35d
Compare
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Instead of ConnectAll and DisconnectAll use the Connect and Disconnect functions to connect and disconnect to and from individual NVMe/TCP targets (SDTs). If no SDTs (powerflex.sdt) are provided discover them by querying the PowerFlex REST API. Signed-off-by: Julian Pelizäus <[email protected]>
…g key Don't anymore set powerflex.sdt config key if not provided. If it's not set the driver will discover the list of NVMe/TCP targets (SDTs) from the PowerFlex REST API. Signed-off-by: Julian Pelizäus <[email protected]>
…ing place Signed-off-by: Julian Pelizäus <[email protected]>
This allows using the connectors functionality to conveniently check if the respective SDC kernel module got already loaded outside of LXD. Signed-off-by: Julian Pelizäus <[email protected]>
…ation Rely on the already existing check in Validate() to check if the SDC kernel module got loaded outside of LXD. Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
powerflex_connect
branch
3 times, most recently
from
ec263cc to
ae4cc7c
Compare
Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
powerflex_connect
branch
from
ae4cc7c to
66a477f
Compare
Closes #14814
This aligns the PowerFlex driver with the implementation of Pure in #14599 to use the NVMe/TCP
ConnectandDisconnectfunctions instead of their(Connect|Disconnect)Allcounterparts.Furthermore a patch is introduced to remove the
powerflex.sdtconfig key from already existing storage pools.Currently only a single address is stored in the key and using
nvme connect-allall of the other targets (SDTs) are discovered anyway.As the driver is now querying for all the SDTs in case
powerflex.sdtconfig key is not set, the behavior is the exact same.In addition
powerflex.sdtnow accepts multiple addresses separated by comma which allows overriding the addresses discovered by asking the PowerFlex REST API.Some additional minor tweaks have been put into place to make more consistent use of the connector's
LoadModulesin case of SDC and to clean up some error messages.