-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM: Apply mount options to hotplugged disks #14898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f45819
to
4a65e35
Compare
4a65e35
to
120e907
Compare
Two possible improvements for the future:
|
tomponline
reviewed
Feb 3, 2025
tomponline
reviewed
Feb 3, 2025
08aa340
to
37370ac
Compare
@tomponline this should be ready to merge |
tomponline
reviewed
Feb 4, 2025
tomponline
reviewed
Feb 4, 2025
tomponline
reviewed
Feb 4, 2025
f03637e
to
0fed3f6
Compare
tomponline
reviewed
Feb 5, 2025
This applies to the 'ro' flag when `readonly` is enabled, but could be extended to also use options provided through `raw.mount.options` or other config key. Signed-off-by: hamistao <[email protected]>
Uses `RunCommandContext` to avoid the deprecated `RunCommand` Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
0fed3f6
to
43a26ea
Compare
tomponline
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tomponline
added a commit
to canonical/lxd-ci
that referenced
this pull request
Feb 8, 2025
Tests for canonical/lxd#14898. I am assuming it will be backported into 5.21. If not, let me know and I shall update the tests accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13677
Related CI tests in: canonical/lxd-ci#403