Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LXD: Sites #14884

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

LXD: Sites #14884

wants to merge 17 commits into from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Jan 29, 2025 •
edited
Loading

This is a draft PR for LXD sites.

This PR will also include support for scheduled refreshes of instances across sites.

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 29, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from 06209b4 to 0bfbd6f Compare January 29, 2025 23:32
@kadinsayani
Copy link
Contributor Author

kadinsayani commented Jan 29, 2025 •
edited
Loading

The failing CodeQL security check is due to the join token being passed in as user input to the POST /1.0/site/join request - we use the addresses from the join token when calling GetRemoteCertificate. We do the same in lxd init interactive: https://github.com/canonical/lxd/blob/main/lxd/main_init_interactive.go#L175-L190.

@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from 7cbdfa6 to 3783d48 Compare February 4, 2025 21:30
@kadinsayani kadinsayani changed the title LXD: Server side remotes and remote clusters LXD: Sites Feb 4, 2025
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 3 times, most recently from ed12163 to fa78411 Compare February 5, 2025 22:54
MusicDin
MusicDin reviewed Feb 6, 2025
View reviewed changes
client/lxd_sites.go Outdated Show resolved Hide resolved
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from fd35a8a to 38101f9 Compare February 9, 2025 21:23
@kadinsayani
api: Add sites extension
8a4a8ef 
Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani kadinsayani force-pushed the lxd-remotes branch 5 times, most recently from a43ad68 to b5cd7ef Compare February 11, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusicDin MusicDin MusicDin left review comments

@tomponline tomponline Awaiting requested review from tomponline

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadinsayani @MusicDin