Backports (stable-5.0) #14268
Merged
Backports (stable-5.0) #14268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call to liblxc Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit 6c6861a)
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 8588326)
In CI, untar'ing backups lead to those warnings about time discrepancies:
```
+ tar -xzf /home/runner/work/lxd/lxd/test/tmp.yy0/T5U/testvol.tar.gz -C /home/runner/work/lxd/lxd/test/tmp.yy0/T5U/non-optimized
tar: backup/index.yaml: time stamp 2024-10-04 13:47:24 is 0.053552327 s in the future
tar: backup/volume-snapshots/test-snap0/test: time stamp 2024-10-04 13:47:24 is 0.053404079 s in the future
tar: backup/volume-snapshots/test-snap0: time stamp 2024-10-04 13:47:24 is 0.053373382 s in the future
tar: backup/volume-snapshots/test-snap1/test: time stamp 2024-10-04 13:47:24 is 0.053263225 s in the future
tar: backup/volume-snapshots/test-snap1: time stamp 2024-10-04 13:47:24 is 0.053238839 s in the future
tar: backup/volume/test: time stamp 2024-10-04 13:47:24 is 0.053151806 s in the future
tar: backup/volume: time stamp 2024-10-04 13:47:24 is 0.053119726 s in the future
```
According to `man 1 tar`, `--warning=no-timestamp` would ignore the following
warnings:
```
timestamp
"%s: implausibly old time stamp %s"
"%s: time stamp %s is %s s in the future"
```
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit d3cd178)
The CAP_SYS_ADMIN cap is required for rsync to write to files using security.* xattrs. In order to preserve these xattrs and ensure proper updates when these xattrs are present, we must include this capability in the rsync AppArmor profile. Signed-off-by: Mark Bolton <[email protected]> (cherry picked from commit 38a2cac)
This is a precursor to potentially using it for the callhook handler for container stops. Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit 1103985)
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Adds the `callhook` subcommand and a `callhook` package for handling stop hook requests from LXD containers. These are then passsed to the LXD server via its UNIX socket. Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit a7b7c50)
To avoid duplicating logic. Signed-off-by: Thomas Parrott <[email protected]> (cherry picked from commit b0fa898)
This task is running every minute but doesn't need to, because token expiry is checked at the time of use. Additionally, a comment where the task is added to the daemon specifies that it runs hourly. Signed-off-by: Mark Laing <[email protected]> (cherry picked from commit 9e8aabb)
With this, processes spawned by lxc exec and stop due to being signaled now return the proper exit code to LXD. Signed-off-by: hamistao <[email protected]> (cherry picked from commit f9d5fbd)
Do this instead of testing a clean stop as cleanly stop can be unpredictable. Signed-off-by: hamistao <[email protected]> (cherry picked from commit 721d358)
This hasn't raised problems so far but you never know ;) Signed-off-by: hamistao <[email protected]> (cherry picked from commit 0a5b448)
…ter once done Signed-off-by: Simon Deziel <[email protected]> (cherry picked from commit 1f7d95d)
Build all LXD related binaries as default target Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
MusicDin
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.