Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test dqlite fix branch #14034

Closed
wants to merge 1 commit into from
Closed

Test dqlite fix branch #14034

wants to merge 1 commit into from

Conversation

cole-miller
Copy link
Contributor

This isn't intended for merging, it's just to check that this PR doesn't break LXD before merging.

@cole-miller cole-miller force-pushed the check-dqlite-change branch 2 times, most recently from 3754ab9 to 67c3e7e Compare September 3, 2024 15:51
@cole-miller
Copy link
Contributor Author

Looks like there's a bug indeed.

@tomponline
Copy link
Member

@cole-miller do you want to keep this open?

@cole-miller cole-miller closed this Sep 5, 2024
@cole-miller
Copy link
Contributor Author

@tomponline Thanks, will open a new PR when I believe I have a fix.

@cole-miller cole-miller mentioned this pull request Oct 8, 2024
Merged
@cole-miller cole-miller reopened this Oct 10, 2024
@cole-miller
Tests
a360343 
Signed-off-by: Cole Miller <[email protected]>
@cole-miller
Copy link
Contributor Author

Reopened to run the tests again after fixing the original issue that was causing a dqlite crash, this time everything looks good except https://github.com/canonical/lxd/actions/runs/11281068099/job/31375983596 which I'm having trouble interpreting---@tomponline or @simondeziel does it look like dqlite is misbehaving there?

@simondeziel
Copy link
Member

Reopened to run the tests again after fixing the original issue that was causing a dqlite crash, this time everything looks good except https://github.com/canonical/lxd/actions/runs/11281068099/job/31375983596 which I'm having trouble interpreting---@tomponline or @simondeziel does it look like dqlite is misbehaving there?

Doesn't sound like it, I'm retrying it.

@tomponline
Copy link
Member

@cole-miller is this still needed?

@tomponline tomponline closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cole-miller @tomponline @simondeziel