feat: [WD-14036] Duplicate instance (lxc copy)

[Kxiru]

Done

• Added DuplicateInstance Button and Form
• Added duplicate instance API call.

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Navigate to an instance
   • Select "Duplicate instance" in header.
   • Fill out form and select "Duplicate & Create"
   • Verify that another instance has been created with the same details.

Screenshots

[webteam-app]

Demo

Jenkins

demos.haus

[piperdeck]

So I'm getting an error where it says it can't find the instance I'm duplicating in the project I've selected. Is it possible that the project dropdown is being used to look for the source instance, rather than specifying the destination?

CleanShot.2024-08-15.at.20.58.31.mp4

[edlerd]

Some observations

• the "Duplicate & start" copy on the new modal deviates from the "Create and start" copy on creation. We should better align those
• the copy "Created and started cloned instance abcd-1." of the success notification reads very odd to me.
• the copy "Creation for instance abcd-1 started." does not transport that this is a clone operation. I am not sure if this is the right thing to say in this event.
• I think we can simplify by duplicating and not starting the cloned instance? Currently, we have a complex series of multiple API calls going on, adding complexity on error handling.

[edlerd]

Thanks for the adjustments, this looks much cleaner already. Two further suggestions below.

[Kxiru]

Alrighty, that's all been covered, @edlerd , please let me know what you think :)

[Kxiru]

Got this strange cryptic error:
...

Hey, Piper,
I have not been able to recreate your issue. I am doing some investigation as I have not seen this error before, but the initial problem that you mentioned has been addressed, and yes, now duplicated instances are set in the correct project.

• Are you running/testing the branch locally in a clustered environment or within the demo server?
• Currently, I am having issues with the demo server. Could you tell me more about the instance you are trying to duplicate? Such as it's base image and instance type?
• When duplicating other randomly selected instances locally and in the demo server, I do not come across this error. Are you having this issue across multiple different instances?

[edlerd]

LGTM

[Kxiru]

@Kxiru ,

• Validate instance name(s) and increment tail if name already in use.
• Center modal when screen is minimised.

[edlerd]

One last comment on the hook for the deduplication, and there is the open discussion on the CSS change, then this should be good from my side.

[mas-who]

@Kxiru just a few minor comments from my end and also good to go, great work! :)

[edlerd]

LGTM, thanks for adding the duplication!