Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to vite 5 #608

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 17, 2024

Done

  • updated all dependencies
  • adjust config
  • adjust formatting

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check build and ci passes
    • spot check demo server

@webteam-app
Copy link

Demo starting at https://lxd-ui-608.demos.haus

@edlerd edlerd force-pushed the update-dependencies branch 15 times, most recently from 151a935 to 22f509a Compare January 17, 2024 23:43
@mas-who
Copy link
Collaborator

mas-who commented Jan 18, 2024

Reviewed the changes, looks good, just leaving this Vite v4 to v5 migration guide here for reference: https://vitejs.dev/guide/migration.html.

QA on the demo server looks mostly okay, clicked on all tabs and spot checked most actions (links, buttons etc). Only saw one issue, when I tried to access the terminal, or console for an instance the below error pops up
Screenshot from 2024-01-18 09-47-48

I checked on demo 307 and terminal session works fine there. So I think it's got to do with some related dependency update?

@edlerd edlerd force-pushed the update-dependencies branch from 22f509a to fc66dd7 Compare January 18, 2024 08:06
@edlerd
Copy link
Collaborator Author

edlerd commented Jan 18, 2024

QA on the demo server looks mostly okay, clicked on all tabs and spot checked most actions (links, buttons etc). Only saw one issue, when I tried to access the terminal, or console for an instance the below error pops up

Well spotted, thanks! I reverted the xterm-addon-fit dependency. It expects xterm5, but xterm-react is limited to xterm 4. We should look into this independently. Also we shoudl add a test case for the terminal. I'll create some follow ups for both.

@mas-who
Copy link
Collaborator

mas-who commented Jan 18, 2024

QA on the demo server looks mostly okay, clicked on all tabs and spot checked most actions (links, buttons etc). Only saw one issue, when I tried to access the terminal, or console for an instance the below error pops up

Well spotted, thanks! I reverted the xterm-addon-fit dependency. It expects xterm5, but xterm-react is limited to xterm 4. We should look into this independently. Also we shoudl add a test case for the terminal. I'll create some follow ups for both.

Thanks David for the update! Just checked again and all seems good now 👍

@edlerd edlerd merged commit a3a7dd4 into canonical:main Jan 18, 2024
6 checks passed
@edlerd edlerd deleted the update-dependencies branch January 18, 2024 08:36
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants