-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to vite 5 #608
Conversation
Demo starting at https://lxd-ui-608.demos.haus |
151a935
to
22f509a
Compare
Reviewed the changes, looks good, just leaving this Vite v4 to v5 migration guide here for reference: https://vitejs.dev/guide/migration.html. QA on the demo server looks mostly okay, clicked on all tabs and spot checked most actions (links, buttons etc). Only saw one issue, when I tried to access the terminal, or console for an instance the below error pops up I checked on demo 307 and terminal session works fine there. So I think it's got to do with some related dependency update? |
Signed-off-by: David Edler <[email protected]>
22f509a
to
fc66dd7
Compare
Well spotted, thanks! I reverted the xterm-addon-fit dependency. It expects xterm5, but xterm-react is limited to xterm 4. We should look into this independently. Also we shoudl add a test case for the terminal. I'll create some follow ups for both. |
Thanks David for the update! Just checked again and all seems good now 👍 |
Done
QA