-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement scrollable form components [WD-8093] #603
Conversation
Demo starting at https://lxd-ui-603.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The right scrolling behaviour is missing on
- instance/profile creation/edit > disk devices
- network>bridge, dns, ipv4 and ipv6
- storage volume > snapshots, filesystem
- storage pool > ceph
380bb64
to
134bdeb
Compare
Oh that is interesting. I assumed that all the config tables are already scrollable. I will do a scan through and make sure everything has consistent behaviour. |
134bdeb
to
0dfc9a0
Compare
Picked up two more sections that was missing the same behaviour:
|
0dfc9a0
to
e3f4515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding all the forms and aligning their layout. Some ideas to simplify and generalize below.
One thing I realized: the min-width
of the form-navigation
is too low, if we increase it to 14rem
, we avoid a vertical scrollbar if the screen is too small to fit the whole expanded menu on the screen. Maybe we can increase it as part of this PR?
e3f4515
to
7e85c0e
Compare
117d664
to
7e16b02
Compare
Signed-off-by: Mason Hu <[email protected]>
7e16b02
to
d21629e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making all the forms consistent and fix them for smaller resolutions!
Done
QA
Screenshots
Example
