Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement scrollable form components [WD-8093] #603

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Jan 15, 2024

Done

  • Implemented scrollable form component for all main configuration sections across the app (creation and edit)
  • aligned scrollable behaviour for existing forms and tables across the application

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check all main configuration sections, make sure that the form is scrollable but not the document body
    • Check instance creation and edit, network creation and edit, profile creation and edit, storage pool creation and edit, storage volume creation and edit, project creation and edit

Screenshots

Example
Screenshot from 2024-01-15 18-31-27

@webteam-app
Copy link

Demo starting at https://lxd-ui-603.demos.haus

@mas-who mas-who changed the title feat: implement scrollable form components feat: implement scrollable form components [WD-8093] Jan 15, 2024
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right scrolling behaviour is missing on

  • instance/profile creation/edit > disk devices
  • network>bridge, dns, ipv4 and ipv6
  • storage volume > snapshots, filesystem
  • storage pool > ceph

@mas-who mas-who force-pushed the scrollable-form-component branch from 380bb64 to 134bdeb Compare January 16, 2024 07:47
@mas-who
Copy link
Collaborator Author

mas-who commented Jan 16, 2024

The right scrolling behaviour is missing on

  • instance/profile creation/edit > disk devices
  • network>bridge, dns, ipv4 and ipv6
  • storage volume > snapshots, filesystem
  • storage pool > ceph

Oh that is interesting. I assumed that all the config tables are already scrollable. I will do a scan through and make sure everything has consistent behaviour.

@mas-who mas-who force-pushed the scrollable-form-component branch from 134bdeb to 0dfc9a0 Compare January 16, 2024 08:22
@mas-who mas-who requested a review from edlerd January 16, 2024 08:24
@mas-who
Copy link
Collaborator Author

mas-who commented Jan 16, 2024

The right scrolling behaviour is missing on

  • instance/profile creation/edit > disk devices
  • network>bridge, dns, ipv4 and ipv6
  • storage volume > snapshots, filesystem
  • storage pool > ceph

Oh that is interesting. I assumed that all the config tables are already scrollable. I will do a scan through and make sure everything has consistent behaviour.

Picked up two more sections that was missing the same behaviour:

  • storage volume > zfs
  • network > network forward create/edit

@mas-who mas-who force-pushed the scrollable-form-component branch from 0dfc9a0 to e3f4515 Compare January 16, 2024 08:26
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding all the forms and aligning their layout. Some ideas to simplify and generalize below.

One thing I realized: the min-width of the form-navigation is too low, if we increase it to 14rem, we avoid a vertical scrollbar if the screen is too small to fit the whole expanded menu on the screen. Maybe we can increase it as part of this PR?

@mas-who mas-who force-pushed the scrollable-form-component branch from e3f4515 to 7e85c0e Compare January 16, 2024 10:57
@mas-who mas-who force-pushed the scrollable-form-component branch 2 times, most recently from 117d664 to 7e16b02 Compare January 16, 2024 14:35
@mas-who mas-who force-pushed the scrollable-form-component branch from 7e16b02 to d21629e Compare January 16, 2024 15:28
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making all the forms consistent and fix them for smaller resolutions!

@mas-who mas-who merged commit 6180c5c into canonical:main Jan 16, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants