Skip to content

Commit

Permalink
volume snapshots can have an empty expiry (#1011)
Browse files Browse the repository at this point in the history
## Done

- fix volume snapshots, they can have an empty expiry, and we should
show that correctly

## QA

1. Run the LXD-UI:
- On the demo server via the link posted by @webteam-app below. This is
only available for PRs created by collaborators of the repo. Ask
@mas-who or @edlerd for access.
- With a local copy of this branch, [build and run as described in the
docs](../CONTRIBUTING.md#setting-up-for-development).
2. Perform the following QA steps:
- create a custom volume, create snapshots without a name or expiry on
that volume, browse the snapshot list of that volume.

## Screenshots

Before:


![image](https://github.com/user-attachments/assets/acf34012-3698-4f79-a091-e1c10e678e51)


After:


![image](https://github.com/user-attachments/assets/535109f4-51c6-49c7-9864-5992056d2fb7)
  • Loading branch information
edlerd authored Nov 26, 2024
2 parents 6a7b744 + e8295c5 commit 49da9c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/util/helpers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { FormDevice } from "./formDevices";
export const UNDEFINED_DATE = "0001-01-01T00:00:00Z";

export const isoTimeToString = (isoTime: string): string => {
if (isoTime === UNDEFINED_DATE) {
if (isoTime === UNDEFINED_DATE || !isoTime) {
return "";
}

Expand Down

0 comments on commit 49da9c2

Please sign in to comment.