-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update charm 1.8.0-rc.0 #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NohaIhab !
I think we are also missing the following env variables on the pebble layer:
DASHBOARD_LINKS_CONFIGMAP
POD_NAMESPACE
- this one we can set it toself.model.name
for now and leave a comment referencing Discuss deployment in non-kubeflow namespace bundle-kubeflow#698, even if we don't fully support changing the namespace atm, we will be prepared.
@DnPlas due to this issue kubeflow/kubeflow#6622 we are setting the kubeflow-dashboard-operator/src/charm.py Line 171 in 7ea87c4
the issue is still valid in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NohaIhab
Summary of changes
profiles
resource from Auth manifests, this resource was needed for creating theadmin
profile, which is no longer applicable.POD_NAMESPACE
env var, for context see the issue Discuss deployment in non-kubeflow namespace bundle-kubeflow#698