Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update charm 1.8.0-rc.0 #163

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Sep 13, 2023

Summary of changes

  • Bump image version to v1.8.0-rc.0 in preparation for the 1.8 release based on kubeflow/manifests repo tag v1.8.0-rc.0.
  • Remove unused profiles resource from Auth manifests, this resource was needed for creating the admin profile, which is no longer applicable.
  • Set the newly added POD_NAMESPACE env var, for context see the issue Discuss deployment in non-kubeflow namespace bundle-kubeflow#698

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab !

I think we are also missing the following env variables on the pebble layer:

tests/integration/test_charm.py Show resolved Hide resolved
@NohaIhab
Copy link
Contributor Author

@DnPlas due to this issue kubeflow/kubeflow#6622 we are setting the DASHBOARD_CONFIGMAP env variable instead

"DASHBOARD_CONFIGMAP": self._configmap_name,

the issue is still valid in 1.8.0-rc.0, see here

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab

@NohaIhab NohaIhab merged commit b3e7e84 into main Sep 14, 2023
@NohaIhab NohaIhab deleted the kf-4214-feat-update-charm-1.8.0-rc.0 branch September 14, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants