Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Decrease resyncPeriodSeconds to 1 min (#539) #555

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Backport: Decrease resyncPeriodSeconds to 1 min (#539) #555

merged 5 commits into from
Jul 31, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Jul 31, 2024

@misohu misohu requested a review from a team as a code owner July 31, 2024 07:17
DnPlas and others added 5 commits July 31, 2024 10:43
@DnPlas @misohu
fix: remove deprecated prime part from charmcraft.yaml file (#545)
fb37280 
Remove the prime key from the charm part and instead move it to its dedicated scripts part
to generate a valid charm. The prime key has been deprecated and charmcraft 3.x and will no longer
build valid charms that can be deployed.

Fixes #544
@DnPlas @misohu
ci: bump python-libjuju 3.2.x -> 3.5.x (#546)
c02f22d 
* ci: bump juju 3.2.x -> 3.5.x
@DnPlas @misohu
tests, build, ci: refactor test_viz_server_healthcheck and separate r…
71fdbc3 
…equirements-integration for v1 and v2 SDK (#551)

* build, ci: separate requirements-integration for v1 and v2 SDK

The kfp SDK may have different requirements for each version, so it makes sense to keep
them in separate files to avoid conflicting packages.

* tests: refactor test_viz_server_healthcheck to use sh.juju_status for url

Using sh.juju_status will prevent the test case from calling ops_test.model.get_status(), which appears to be
failing. The reason why the latter fails is still unknown, but this commit will allow us to unblock the CI for now.

Part of #549
@DnPlas @misohu
build: bump jinja2 3.1.x -> 3.1.4 and remove jinja2 from binary packa…
3d30d72 
…ges (#543)

Part of canonical/bundle-kubeflow#883
@misohu
Decrease resyncPeriodSeconds to 1 min (#539)
f820215 
Part of canonical/bundle-kubeflow#951
@misohu misohu force-pushed the KF-5915-backport-resync-period branch from f5fe798 to f820215 Compare July 31, 2024 08:43
@misohu misohu changed the title Decrease resyncPeriodSeconds to 1 min (#539) Backport: Decrease resyncPeriodSeconds to 1 min (#539) Jul 31, 2024
DnPlas
DnPlas approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu ! Make sure to use a merge commit to merge these changes and ensure the charm is published to 2.0/edge and 2.0/stable after merging.

@misohu misohu merged commit e6b9889 into track/2.0 Jul 31, 2024
46 checks passed
@misohu misohu deleted the KF-5915-backport-resync-period branch July 31, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misohu @DnPlas