-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document charm commands #938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @eaudetcobello, thanks a lot! Left some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Etienne! Let's add a little bit of context here and there.
@eaudetcobello should we close this PR or do you plan to refactor it to link to Charmhub? |
@bschimke95 Thanks for the nudge, I linked to charmhub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think referring to actions
as commands
might cause confusion in the long run. I know we want to merge this with the commands
page from the snap, but that feels a bit odd. @nhennigan do you think we should at least clarify this on the page, or completely change the naming to better reflect the charm mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍨 Yum. Let's go
I think renaming the page makes the most sense. I was unaware of the difference in naming here. We can look at combining at a later stage. For now, we should go with what makes the most sense under the charm tree. Thanks for bringing it up. After the name change / title change it is good to go thanks Etienne 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just check the nit before merging
Co-authored-by: Mateo Florido <[email protected]>
Document charm commands
This PR documents the k8s charm commands.