Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a systemd override to add containerd defaults #932

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

berkayoz
Copy link
Member

@berkayoz berkayoz commented Jan 8, 2025

Closes #718

Adds a systemd .conf override file to match upstream recommendations, see https://github.com/containerd/containerd/blob/release/1.6/containerd.service for example

File is only copied over if it does not exist to make sure changes are not over-written

This approach might not work in strict as we are editing /etc/systemd/...

@berkayoz berkayoz requested a review from a team as a code owner January 8, 2025 12:38
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit cf3bb9b into main Jan 9, 2025
19 checks passed
@bschimke95 bschimke95 deleted the KU-1828/containerd-service-defaults branch January 9, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to manually set LimitNOFILE in the containerd service file
2 participants