Update metallb version to 0.14.8 #805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eaudetcobello
commented
Nov 15, 2024
•
eaudetcobello
commented
- Bump metallb chart to v0.14.8
- Add convenience update-metallb-chart.py script
- Change image repos to github.com/canonical/metallb-{controller,speaker}
- Don't bump frr since we don't enable it and don't offer a way to enable it
addyess
reviewed
Nov 15, 2024
| - source: quay.io/metallb/controller:v0.14.5 | ||
| target: ghcr.io/canonical/k8s-snap/metallb/controller:v0.14.5 | ||
| - source: quay.io/metallb/controller:v0.14.8 | ||
| target: ghcr.io/canonical/k8s-snap/metallb/controller:v0.14.8 |
There was a problem hiding this comment.
wait? isn't it this:
Suggested change
| target: ghcr.io/canonical/k8s-snap/metallb/controller:v0.14.8 | |
| target: ghcr.io/canonical/metallb-controller:v0.14.8 |
There was a problem hiding this comment.
No, but this file is outdated anyway when it comes to images we build rocks for. It used to be that we pulled the images from quay and synced them to ghcr. But now we build the rocks. We don't want quay images to replace the rocks.
eaudetcobello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.