Unittests for cilium k8sd feature #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maci3jka
force-pushed
the
KU-1517/cilium-unittests
branch
from
48d1ff3
to
7cb185b
Compare
|
adresses also KU-1516 |
There was a problem hiding this comment.
Thanks a lot @maci3jka! Great work. Almost LGTM, but left some minor comments.
eaudetcobello
requested changes
Sep 30, 2024
Comment on lines
139
to
144
| g.Expect(status.Message).To(Equal(fmt.Sprintf(cilium.IngressDeployFailedMsgTmpl, | ||
| fmt.Errorf("failed to rollout restart cilium to apply ingress: %v", | ||
| fmt.Errorf("failed to restart cilium-operator deployment after 3 attempts: %w", | ||
| fmt.Errorf("failed to restart cilium-operator deployment: %w", | ||
| fmt.Errorf("failed to get deployment cilium-operator in namespace kube-system: %w", | ||
| errors.New("deployments.apps \"cilium-operator\" not found"))))), |
There was a problem hiding this comment.
This is too tightly coupled to the message structure and contents. I see several instances of testing the specific error message in this PR, can those be reverted? I would much rather use a simple errors.Is, if possible.
There was a problem hiding this comment.
I misunderstood other review comments. I updated the test. Regarding errors when it makes sense i use gomega expect(err).To(ErrorMatch()) which checks if the error is in the chain of errors will that be enough?
eaudetcobello
approved these changes
Oct 2, 2024
HomayoonAlimohammadi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lacks in unittest for cilium feature in k8sd this pr proves test coverage form 42.9% files, 44.4% statements to 85.7% files, 86.7% statements for github.com/canonical/k8s/pkg/k8sd/features/cilium package