Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Nightly Test runs to pass #701

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Improve Nightly Test runs to pass #701

merged 6 commits into from
Oct 8, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Sep 27, 2024 •
edited
Loading

Overview

Resolves a number of tests issues the nightly tests were having to run effectively on arm64 and amd64 units.

Details

  • Changes to the github workflow definition
    • Use system-wide tox installed through apt for arm64 workers to use
    • Correctly upload the right TEST_SNAP after its downloaded
    • Include inspection reports in failures
    • Add tmate session for remote debugging
  • Add support for arm64 in the etcd tests (correct release url, correct systemd file)
  • Address pytest syntax issue for use of pytest.mark.xfail
  • Adjust the testing tox.ini to be tox 3 and 4 compatible

@addyess addyess requested a review from a team as a code owner September 27, 2024 03:55
@addyess addyess force-pushed the KU-1609/repair-nightly-test branch 12 times, most recently from ad8c14b to 6172383 Compare September 27, 2024 14:22
addyess
addyess commented Sep 27, 2024
View reviewed changes
tests/integration/tests/test_version_upgrades.py
@pytest.mark.xfail("cilium failures are blocking this from working")
@pytest.mark.xfail(reason="cilium failures are blocking this from working")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repairs a syntax error on this xfail call

addyess
addyess commented Sep 27, 2024
View reviewed changes
tests/integration/tests/test_util/harness/base.py
Comment on lines +33 to +38
@cached_property
def arch(self) -> str:
return self.exec(
["dpkg", "--print-architecture"], text=True, capture_output=True
).stdout.strip()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! an instance can know what architecture its running on

addyess
addyess commented Sep 27, 2024
View reviewed changes
tests/integration/tox.ini
@@ -1,47 +1,46 @@
[tox]
no_package = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes are to make this more compatible with tox 3. Why tox 3? Because that's what you get with apt on focal and jammy. Why not pip install it? Arm64 runners were having severe trouble loading python libraries from a virtual env on the GH runners for reasons i never was able to understand. I think it's a combination of running tox with sg but i'm not sure. LD_PYTHON_PATH got lost though -- using the system-wide tox improves this

@addyess addyess changed the title Use the correct snap when upgrading Improve Nightly Test runs to pass Sep 27, 2024
bschimke95
bschimke95 reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. I added some comments.

Btw, just a general comment : We eventually need to refactor this nightly test in the future since e.g. we have release independent tests (upgrade tests) and release dependent tests with various flavours.

.github/workflows/nightly-test.yaml Show resolved Hide resolved
tests/integration/templates/etcd/etcd.service Show resolved Hide resolved
tests/integration/tests/test_version_upgrades.py Show resolved Hide resolved
@addyess addyess force-pushed the KU-1609/repair-nightly-test branch from 18f8c65 to f8357a7 Compare October 7, 2024 02:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Hi, looks like pyspelling job found some issues, you can check it here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Hi, looks like pyspelling job found some issues, you can check it here

bschimke95
bschimke95 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@addyess addyess merged commit 43ab3b8 into main Oct 8, 2024
21 checks passed
@addyess addyess deleted the KU-1609/repair-nightly-test branch October 8, 2024 17:03
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
@addyess @evilnick
Improve Nightly Test runs to pass (canonical#701)
984452e 
* Use the correct snap when upgrading
* Make etcd tests arch aware
* bump etcd version to 3.4.34
* Only use tmate if we're debugging a pull-reqeust
* bump metrics server version that contains ARM fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @bschimke95