Add CAPI endpoints for Certificates Refresh #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Sep 26, 2024
|
@HomayoonAlimohammadi @bschimke95 I have created a new PR for including this endpoints. I will cut a release and update the endpoints once this is merged: canonical/k8s-snap-api#10 |
mateoflorido
requested review from
HomayoonAlimohammadi,
bschimke95 and
eaudetcobello
eaudetcobello
approved these changes
Sep 26, 2024
berkayoz
reviewed
Sep 27, 2024
bschimke95
approved these changes
Sep 30, 2024
evilnick
pushed a commit
to evilnick/k8s-snap
that referenced
this pull request
Nov 14, 2024
Refactor Certificates Refresh endpoints to flush the response early and restart the services asynchronously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add new CAPI endpoints to manage certificates refreshes
Rationale
In this pull request, we have added a new set of handlers that allow access from CAPI to the refresh certificates endpoints using the node token as the authentication mechanism. Additionally, we have modified the handler to return the certificate refresh response earlier, deferring the restart until after the response has been flushed. Also, added a couple of drive-by fixes related to the RPC endpoints for Certificates Refreshes.