Add IPv6-only support for moonray #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this might be a good candidate for improvements later on, to use uniform representations. |
|
This is not something we directly control as those come from third-parties (e.g. microcluster). Unifying them just to use them once a few lines later in a util does not seem practical to me. That being said, we should definitely do it where applicable. |
berkayoz
reviewed
Sep 16, 2024
|
Thanks for all the comments! I refactored this PR a bit to pass down the local address rather then determine it in every function separately. |
cdkbot
force-pushed
the
main
branch
6 times, most recently
from
2519611
to
6748308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for IPv6-only support on moonray. For the default k8s-snap this is not yet supported as Cilium loadbalancer does not support IPv6-only.
Most of the changes basically only ensure that the IPv6 address is properly put into brackets. We use different representations of IPs across the codebase (e.g. string, or net.IP or Addr by microcluster) so we cannot just simply use the same approach everywhere.