Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock snap for microcluster tests #1045

Merged

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Feb 5, 2025

Not setting the snap might cause a panic when using the isolated
microcluster tests.

Not setting the snap might cause a panic when using the isolated
microcluster tests.
@bschimke95 bschimke95 force-pushed the bschimke95/investigate-k8s-dqlite-downgrade-unittest-failure branch from d48d72c to 5c806cc Compare February 18, 2025 09:40
@bschimke95 bschimke95 changed the title Downgrade k8s-dqlite and investigate why this breaks the go tests Add mock snap for microcluster tests Feb 18, 2025
@bschimke95 bschimke95 marked this pull request as ready for review February 18, 2025 09:41
@bschimke95 bschimke95 requested a review from a team as a code owner February 18, 2025 09:41
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks a lot @bschimke95! LGTM

@bschimke95 bschimke95 merged commit ac160ac into main Feb 18, 2025
19 checks passed
@bschimke95 bschimke95 deleted the bschimke95/investigate-k8s-dqlite-downgrade-unittest-failure branch February 18, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants