feat: add the send invitation email cli command for admin to compensate user invitation email failure #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wood-push-melon
commented
Sep 25, 2024
wood-push-melon
commented
Sep 25, 2024
wood-push-melon
commented
Sep 25, 2024
pik4ez-canonical
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM.
I would assume that panic shouldn't be used wherever possible to gracefully handle the error (read as: most of the cases). But I see that currently it is widely used in the Admin UI repo, so shouldn't be a blocker for this PR. Most likely it's something that we may consider as a tech debt.
BarcoMasile
previously approved these changes
Sep 26, 2024
wood-push-melon
dismissed stale reviews from BarcoMasile, nsklikas, and pik4ez-canonical
via
34ba19d
wood-push-melon
force-pushed
the
IAM-1049
branch
from
55c2e8e
to
34ba19d
Compare
wood-push-melon
changed the title
nsklikas
approved these changes
Sep 27, 2024
pik4ez-canonical
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to add a CLI command for the admins to compensate for email sending failure in the user invitation flow.