-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-15025 - feat: add built verification email #423
WD-15025 - feat: add built verification email #423
Conversation
b999e2f
to
0d6b14d
Compare
0d6b14d
to
5a43aef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the logo: right now the UI serves assets only under the assets
folder (take a look at this)
If you move the image under the assets folder and adjust the url it will automatically work
The most widely supported method of handling images in HTML emails is to include them as CID attachments. It looks like go-mail supports this, so we'd need the backend service to attach the logo (we'll also need update the template to use an image src with a The other options are to use a CDN like assets.ubuntu.com or use a base64 embed, but these are progressively less supported. |
After reading a little about this, I am curious. It's true that CID is the oldest method of all, but it is not clear if it is the best option. It feels like most people nowadays go with the link option and pull the image from a CDN as it's easier to use and it decreases the size of the mail. I went through emails that I have received from various sites and all of them seem to be using CDN. Can you provide some reading material around or some references? |
There aren't really very good resources on the topic and what info there is is often out of date (e.g. many articles mention CID not working in Gmail, but this is no longer true). The main issue with CDNs is that they are blocked by default in many (all?) clients, but if we're happy with that then we can change this to use the asset server. If we can get the budget for it we can use a mailbox testing tool to see how this email performs in the real world. |
@nsklikas @huwshimi |
I've updated this to load the logo from our CDN (I think this will be more reliable than self hosting on this site). |
Changes
Commit the built email template.
NOTE: the logo needs to be attached by the backend. Not sure if that should be done before landing this PR?
https://warthogs.atlassian.net/browse/WD-15025
QA
kubectl port-forward services/mailhog 18025:8025
)