Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use traefik_route v0 library from traefik-k8s #348

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Use traefik_route v0 library from traefik-k8s #348

merged 2 commits into from
Sep 19, 2024

Conversation

michaeldmitry
Copy link
Contributor

Since traefik_route v0 from traefik_route_k8s is deprecated and is now maintained under traefik_k8s, update all references to point to the new library.

Context

canonical/traefik-route-k8s-operator#60
canonical/traefik-k8s-operator#403
canonical/traefik-route-k8s-operator#61

@michaeldmitry michaeldmitry requested a review from a team as a code owner September 19, 2024 08:34
mmkay
mmkay approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, let's make sure everything still works :)

@michaeldmitry
Copy link
Contributor Author

Codewise looks good, let's make sure everything still works :)

Manually tested with the new library
image

@michaeldmitry michaeldmitry merged commit 124e9c2 into main Sep 19, 2024
13 checks passed
@michaeldmitry michaeldmitry deleted the OPENG-2532 branch September 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkay mmkay mmkay approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldmitry @mmkay