install-plugin action #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
sed-i
reviewed
Mar 22, 2024
| name: | ||
| type: string | ||
| description: | | ||
| Name of the plugin. Must be hosted at https://grafana.com/grafana/plugins`. |
There was a problem hiding this comment.
Would it make more sense to have url as the param?
That would lift the grafana.com restriction and the /plugins/{name}/versions/{version}/download assumption.
Or, if we want to keep the grafana.com restriction, then we could use grafana cli for that, which would be great help with uninstalling (which is currently missing in the PR).
Comment on lines
+1161
to
+1162
| url = f"https://grafana.com/api/plugins/{name}/versions/{version}/download" | ||
| path = Path('/var/lib/grafana/plugins') |
There was a problem hiding this comment.
I would extract path and url to constants
Comment on lines
+1183
to
+1184
| installed_plugins = [o.strip() for o in subprocess.getoutput("grafana cli plugin ls").splitlines()[1:]] | ||
| download_path.unlink() |
There was a problem hiding this comment.
I would put this inside a try...except blick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a development action to download and install into grafana a plugin.
Usage:
juju run grafana install-plugin some-plugin 1.0.0The script will grab the plugin from
grafana.com/api/plugins/some-plugin/versions/1.0.0/downloads, and unzip it into/var/lib/grafana/plugins, then restart grafana and the plugin should be there.Can't test it at the moment because
charmcraft packis bork on main.