Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump tracing library to v14 #157

Merged
merged 3 commits into from
Aug 8, 2024
Merged

fix: bump tracing library to v14 #157

merged 3 commits into from
Aug 8, 2024

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Jul 30, 2024

Fixes canonical/tempo-coordinator-k8s-operator#108

Issue

Fixes canonical/tempo-coordinator-k8s-operator#108

Solution

The new tracing lib automatically removes duplicate packages left over from charm upgrades, preventing the exception raised in canonical/tempo-coordinator-k8s-operator#108. Full detail available in

Context

See tempo fix for more context

Merge after #160

Testing Instructions

juju deploy grafana-agent --revision=134 --channel=latest/stable
juju deploy ubuntu
juju relate grafana-agent ubuntu
# wait for deploy to finish and charm to go to blocked (because it has no target for its metrics)

# Build the updated version of the charm
charmcraft pack  

juju refresh grafana-agent --path ./grafana-agent_ubuntu-22.04-amd64.charm
# charm should refresh and go back to blocked.  It should not go to error

Upgrade Notes

@ca-scribner ca-scribner requested a review from a team as a code owner July 30, 2024 21:05
@ca-scribner ca-scribner changed the title fix: bump tracing library to v12 fix: bump tracing library to v13 Aug 2, 2024
@ca-scribner ca-scribner changed the title fix: bump tracing library to v13 fix: bump tracing library to v14 Aug 6, 2024
Previously, hardware-observer is showing a metric down, resulting in CI failures.  This change pins to a known working version of hardware observer.

See #161 for more details.
@ca-scribner
Copy link
Contributor Author

We should only merge this once this tempo pr is merged

# Conflicts:
#	lib/charms/tempo_k8s/v1/charm_tracing.py
@ca-scribner
Copy link
Contributor Author

Everything is now mergable (assuming it passes CI)

@mmkay mmkay merged commit 115bb39 into main Aug 8, 2024
13 checks passed
@mmkay mmkay deleted the openg-2554-fix branch August 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charm refresh from revision 134 to revision 164 puts all units in error state
2 participants