-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial flask app #2
Conversation
@weiiwang01 Can you take a look, please? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good once the comments from Weii are addressed :)
Test coverage for 4756523
Static code analysis report
|
I'll put the note here as well, we were looking into this, and it seems there is the gunicorn way available as well: https://www.google.com/url?q=https://trstringer.com/logging-flask-gunicorn-the-manageable-way/&sa=D&source=docs&ust=1710249238666567&usg=AOvVaw210jtoz0IaFpGgAiZ48V_m |
@jdkandersson |
Applicable spec: ISD-116 (internal)
Overview
Add the initial flask application. Only the webhook receiving functionality is included. The webhooks are logged into files in a certain directory, which will then be transmitted automatically to Loki using cos integration.
Follow-up PRs will include:
Rationale
A webhook router application is required as defined in the specification.
Checklist
src-docs
urgent
,trivial
,complex
)There is no charm yet, so there are no docs on charmhub.