Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: token endpoint rate limiting #8

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: token endpoint rate limiting #8

merged 2 commits into from
Mar 28, 2024

Conversation

nsklikas
Copy link

IAM-734:

  • This PR implements rate limiting in the token endpoint, using only memory. This is a hacky/messy approach, but it should be ok. Perhaps we should add a flag in hydra for disabling rate-limiting.

@nsklikas nsklikas changed the title Iam 734 fix: token endpoint rate limiting Mar 28, 2024
@nsklikas nsklikas enabled auto-merge March 28, 2024 14:07
shipperizer
shipperizer approved these changes Mar 28, 2024
View reviewed changes
Copy link

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a fan of the name expirationTimer, but cannot find any other option

solid

@nsklikas nsklikas merged commit a42695b into canonical Mar 28, 2024
5 checks passed
@nsklikas nsklikas deleted the IAM-734 branch March 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipperizer shipperizer shipperizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsklikas @shipperizer