Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error handling for authorization pending in device flow #6

Merged
merged 4 commits into from
Mar 21, 2024
Merged

feat: error handling for authorization pending in device flow #6

merged 4 commits into from
Mar 21, 2024

Conversation

wood-push-melon
Copy link

@wood-push-melon wood-push-melon commented Mar 18, 2024 •
edited
Loading

This pull request tries to

  • handle the authorization pending error in the device flow
  • fix the bug when validating the auth/device code expiration
  • re-organize the test cases for access token request handling. Make it easier to read.

@wood-push-melon wood-push-melon requested a review from a team March 18, 2024 16:25
@wood-push-melon wood-push-melon marked this pull request as ready for review March 18, 2024 16:25
nsklikas
nsklikas reviewed Mar 19, 2024
View reviewed changes
Copy link

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have some minor comments, just to keep the changes to a minimum.

handler/oauth2/flow_authorize_code_token_test.go Outdated Show resolved Hide resolved
handler/oauth2/flow_authorize_code_token_test.go Outdated Show resolved Hide resolved
@wood-push-melon wood-push-melon merged commit b5e1e1d into canonical Mar 21, 2024
5 checks passed
@wood-push-melon wood-push-melon deleted the IAM-722 branch March 21, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wood-push-melon @nsklikas