-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the refresh token issue #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this with hydra and the refresh token is still not issued, is this supposed to fix the bug or is there work that needs to be done in hydra for this?
Took another look at the Hydra and Fosite. From what I understand, I think the endpoint With the regular OAuth2 flow, the updated authorize request is stored at this line call. So the access token request handler can use the granted scopes in the authorize request to see if a refresh token should be issued. We can sit together after the daily to have a walkthrough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I have one minor comment
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
This pull request tries to fix the refresh token not issued problem in device flow. Also tries to make some corrections in the tests.
Question:
ClientWithCustomTokenLifespans
. But from this line, do we need to also add something for device flow grant type in here?