Skip to content

Add tests for the window controller on Windows #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Add tests for the window controller on Windows #41

merged 1 commit into from
Apr 9, 2025

Conversation

hbatagelo
Copy link

@hbatagelo hbatagelo commented Apr 4, 2025 •
edited
Loading

What's new

  • A test fixture for testing FFI calls on Windows.
  • Tests covering all existing FFI functions.

@Saviq Saviq force-pushed the multiwindow_ffi_work branch from 3ae68be to 06b22b4 Compare April 7, 2025 15:57
@Saviq Saviq force-pushed the windows_ffi_test branch from cacd0df to f60e10e Compare April 7, 2025 15:59
knopp
knopp reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@knopp knopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this getting merged, I'll do a more thorough review from the final pull request, this seems bit nosy because it changes existing tests.

@Saviq Saviq merged commit da9cccc into multiwindow_ffi_work Apr 9, 2025
1 of 2 checks passed
@Saviq Saviq deleted the windows_ffi_test branch April 9, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopp knopp knopp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbatagelo @knopp @Saviq