Propagate raft_recover errors and improve tracing #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related go-dqlite PR: canonical/go-dqlite#318 |
At the moment, the raft_recover error messages are not propagated, so the caller gets a cryptic error code (1), without further details. This change ensures that the error messages are propagated and adds a few extra trace messages. Furthermore, tracing is disabled unless we start the node (not the case when we're actually trying to recover it). For now, we're adding a "dqliteTracingMaybeEnable" call in "dqlite_node_recover_ext".
petrutlucian94
force-pushed
the
recovery_errmsg
branch
from
4d39111 to
72ff0be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 77.87% 85.67% +7.80%
==========================================
Files 197 197
Lines 27779 29096 +1317
Branches 5538 4089 -1449
==========================================
+ Hits 21633 24929 +3296
+ Misses 4420 3945 -475
+ Partials 1726 222 -1504 ☔ View full report in Codecov by Sentry. |
cole-miller
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the raft_recover error messages are not propagated, so the caller gets a cryptic error code (1), without further details.
This change ensures that the error messages are propagated and adds a few extra trace messages.
Furthermore, tracing is disabled unless we start the node (not the case when we're actually trying to recover it). For now, we're adding a "dqliteTracingMaybeEnable" call in "dqlite_node_recover_ext".