pool: Use uintptr_t for pool thread magic number #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that it's the same size as void *, so that casting to that type won't trigger a diagnostic on any target. This fixes an armhf build failure. Signed-off-by: Cole Miller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 77.87% 77.96% +0.09%
==========================================
Files 197 197
Lines 27953 27954 +1
Branches 5529 5532 +3
==========================================
+ Hits 21767 21793 +26
+ Misses 4346 4322 -24
+ Partials 1840 1839 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that it's the same size as void *, so that casting to that type won't trigger a diagnostic on any target. This fixes an armhf build failure.
Signed-off-by: Cole Miller [email protected]