Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(): Set UNICORN_SIDEKIQ_MAX_RSS env variable #307

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

alithethird
Copy link
Collaborator

@alithethird alithethird commented Dec 9, 2024

Created an option to set the UNICORN_SIDEKIQ_MAX_RSS env variable due to issue

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@alithethird alithethird added enhancement New feature or request trivial urgent labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Test coverage for ebdbb2d

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        373     41     84     15    87%   184, 192-193, 205, 337->345, 378->383, 395, 584-586, 591-592, 604-606, 611-612, 624-626, 649-651, 693->exit, 703->exit, 752-755, 765-766, 790-791, 803-804, 831-833, 835->840, 837-838, 880-881, 897-898, 908->exit, 922
src/database.py      29      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               402     42     92     16    88%

Static code analysis report

Run started:2024-12-09 03:50:51.992777

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2478
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just for my own learning, what does sidekiq do?

@alithethird alithethird merged commit 1f98f1b into main Dec 9, 2024
21 checks passed
@alithethird alithethird deleted the set-unicorn-env-variable branch December 9, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants