Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugins): Bump calendar #195

Closed
wants to merge 1 commit into from
Closed

Conversation

merkata
Copy link
Contributor

@merkata merkata commented Mar 1, 2024

Overview

Bumps the calendar plugin to latest commit.

Rationale

Community request to test the latest commit.

Juju Events Changes

n/a

Module Changes

n/a

Library Changes

n/a

Checklist

@merkata merkata added the trivial label Mar 1, 2024
@merkata merkata requested a review from a team as a code owner March 1, 2024 12:33
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test coverage for 4123b44

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        329     30     80     11    90%   177, 185-186, 350->355, 552-554, 559-560, 571-573, 578-579, 591-593, 598-599, 611-613, 638-640, 682->exit, 692->exit, 722-728, 754->exit, 768-769, 779->exit, 793
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               359     31     88     12    90%

Static code analysis report

Run started:2024-03-01 12:35:17.000840

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1985
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@Thanhphan1147 Thanhphan1147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that the plugin doesn't have some kind of versioning.

@nrobinaubertin
Copy link
Collaborator

nrobinaubertin commented Mar 1, 2024

This new commit is not compatible and the issue that we're trying to fix comes from a mismatch deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants