Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivy exit-code #173

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix trivy exit-code #173

merged 1 commit into from
Jan 17, 2024

Conversation

gtrkiller
Copy link
Contributor

Overview

Stop using exit-code 0 and use .trivyignore instead if required.

Rationale

Using exit-code 0 makes actions run successfully even is there are vulnerabilities.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@gtrkiller gtrkiller requested a review from a team as a code owner January 16, 2024 18:48
@gtrkiller gtrkiller changed the title fix trivy Fix trivy exit-code Jan 16, 2024
Copy link
Contributor

Test coverage for 3d02167

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        328     30     82     11    90%   177, 185-186, 342->347, 540-542, 547-548, 559-561, 566-567, 579-581, 586-587, 599-601, 626-628, 668->exit, 678->exit, 708-714, 740->exit, 754-755, 765->exit, 779
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               358     31     90     12    90%

Static code analysis report

Run started:2024-01-16 18:50:46.703486

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1978
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@merkata merkata merged commit 42b018a into main Jan 17, 2024
26 of 28 checks passed
@merkata merkata deleted the fix_trivy branch January 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants