Implement dss logs functionality. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
reviewed
Mar 22, 2024
|
This PR needs to be postponed until this is resolved #58 |
|
The dss remove command has been discussed with UX team please check the DSS spec here for details about the error messages and parameters. |
misohu
force-pushed
the
KF-5382-implement-logs-command
branch
from
240de2e to
af44012
Compare
|
All the comments from UX team are now part of this PR |
misohu
force-pushed
the
KF-5382-implement-logs-command
branch
from
af44012 to
c495346
Compare
orfeas-k
reviewed
Apr 4, 2024
orfeas-k
reviewed
Apr 4, 2024
misohu
force-pushed
the
KF-5382-implement-logs-command
branch
from
c495346 to
8bbd2b5
Compare
orfeas-k
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please first review this one #62
This PR resolves issue: #33
dss logswith--mlflowand--allflagsHow to test:
If you want to test locally run the steps from .github/workflows/tests.yaml:integration (integration tests)