Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dss snap #42

Merged
merged 4 commits into from
Mar 15, 2024
Merged

feat: add dss snap #42

merged 4 commits into from
Mar 15, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Mar 5, 2024 •
edited
Loading

feat: add dss snap project

This commit adds the snap project for DSS.

Fixes #25

Testing instructions

  1. Clone this repository and build the snap
snapcraft
  1. Install the snap snap install <name of snap>.snap --dangerous
  2. Run dss and see the help printed out:
$ dss
Usage: dss [OPTIONS] COMMAND [ARGS]...

  Command line interface for managing the DSS application.

Options:
  --help  Show this message and exit.

Commands:
  create-notebook  Create a Notebook server.
  initialize       Initialize DSS on the given Kubernetes cluster.

@DnPlas DnPlas force-pushed the KF-5333-dss-snap branch from e37877a to 96bb544 Compare March 5, 2024 09:00
@DnPlas DnPlas force-pushed the KF-5333-dss-snap branch 3 times, most recently from 8d09a4c to e07bc09 Compare March 12, 2024 11:28
@DnPlas
feat: add dss snap project
9b72c44 
This commit adds the snap project for DSS.

Fixes #25
@DnPlas DnPlas force-pushed the KF-5333-dss-snap branch from e07bc09 to 9b72c44 Compare March 12, 2024 13:00
kenvandine
kenvandine requested changes Mar 12, 2024
View reviewed changes
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@DnPlas DnPlas marked this pull request as ready for review March 12, 2024 15:31
@DnPlas DnPlas requested a review from a team as a code owner March 12, 2024 15:31
kenvandine
kenvandine approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great now

orfeas-k
orfeas-k reviewed Mar 14, 2024
View reviewed changes
snapcraft.yaml Outdated Show resolved Hide resolved
snapcraft.yaml Outdated Show resolved Hide resolved
orfeas-k
orfeas-k approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DnPlas 😄

@DnPlas DnPlas merged commit 6f5c827 into main Mar 15, 2024
3 checks passed
@DnPlas DnPlas deleted the KF-5333-dss-snap branch March 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k approved these changes

@kenvandine kenvandine kenvandine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a snapcraft.yaml file for the DSS
3 participants
@DnPlas @kenvandine @orfeas-k