Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initialize #29

Merged
merged 26 commits into from
Feb 28, 2024
Merged

Implement initialize #29

merged 26 commits into from
Feb 28, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Feb 15, 2024

This PR implements #27. To test locally you can check integration tests or:

  1. Install microk8s with hostpath-storage addon
  2. Clone repo and install the library with pip install .
  3. Run dss initialize
dss initialize --kubeconfig="$(microk8s config)"
  1. Dss namespace should be crated and mlflow-deployment should be present inside it.
  2. Search for mlflow-svc in dss namespace and use the ip address to access mlflow ui in browser.

Note: there needs to be echo as its multi line output.

Closes #27

@misohu misohu marked this pull request as ready for review February 15, 2024 10:56
@misohu misohu requested a review from a team as a code owner February 15, 2024 10:56
@misohu misohu marked this pull request as draft February 15, 2024 10:56
@misohu misohu marked this pull request as ready for review February 15, 2024 14:41
src/dss/main.py Outdated Show resolved Hide resolved
src/dss/manifests.yaml Outdated Show resolved Hide resolved
src/dss/manifests.yaml Show resolved Hide resolved
tests/integration/test_dss.py Outdated Show resolved Hide resolved
src/dss/initialize.py Outdated Show resolved Hide resolved
src/dss/main.py Outdated Show resolved Hide resolved
src/dss/main.py Outdated Show resolved Hide resolved
src/dss/initialize.py Outdated Show resolved Hide resolved
Previously, kubeconfig was passed as the content of a kubeconfig file and stored in an environment variable.  This refactor changes inputs to accept a file path kubeconfig to a kubernetes config file, with defaults for when that file is omitted.
@kimwnasptd
Copy link
Collaborator

@ca-scribner the PR looks good as a first iteration!

I'd suggest that we keep the following in mind for next steps:

  1. For now the dss initialize command will only error because of a timeout, but the message will not be helpful on debugging
    1. Let's open bugs anytime we will hit the timeout, and document why it failed. So that we'll gradually improve the error handling
    2. Let's also ask the UX team what the expectation is when this command will fail. Should we urge users to then run dss status or dss logs in the message so that they know how to further go and fix the issue?
  2. ACK for now to just use paths for the kubeconfig, but lets have an issue to document this current limitation (and how it potentially affects the other CLI commands that need a kubeconfig) so that we keep track of it and while working on the snap (and potentially link the issues together)

cc @DnPlas

@ca-scribner ca-scribner merged commit 08657be into main Feb 28, 2024
3 checks passed
@ca-scribner ca-scribner deleted the KF-5335-implement-initialize branch February 28, 2024 15:30
@ca-scribner
Copy link
Contributor

agreed @kimwnasptd, added #37 to capture the kubeconfig task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DSS initialize command
3 participants