-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement initialize #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimwnasptd
reviewed
Feb 16, 2024
ca-scribner
reviewed
Feb 20, 2024
ca-scribner
reviewed
Feb 20, 2024
kimwnasptd
reviewed
Feb 23, 2024
Previously, kubeconfig was passed as the content of a kubeconfig file and stored in an environment variable. This refactor changes inputs to accept a file path kubeconfig to a kubernetes config file, with defaults for when that file is omitted.
@ca-scribner the PR looks good as a first iteration! I'd suggest that we keep the following in mind for next steps:
cc @DnPlas |
kimwnasptd
approved these changes
Feb 28, 2024
agreed @kimwnasptd, added #37 to capture the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #27. To test locally you can check integration tests or:
pip install .
mlflow-deployment
should be present inside it.mlflow-svc
indss
namespace and use the ip address to access mlflow ui in browser.Note: there needs to be echo as its multi line output.
Closes #27