Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Show craft logs instead of uploading to artifact #266

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical commented Jan 15, 2025

Print snapcraft/rockcraft/charmcraft logs to GitHub Actions log instead of uploading log file to artifact

Also show logs on success & failure instead of just on failure

@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Jan 15, 2025

tested on canonical/mysql-router-k8s-operator#362

Copy link

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but old approach was OK for me. Up 2 you here.

Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, being able to see the logs in actions as well as able to be downloaded via artifact -- a solution that includes both would be a icing on the cake in my opinion.

Print snapcraft/rockcraft/charmcraft logs to GitHub Actions log instead of uploading log file to artifact
@carlcsaposs-canonical carlcsaposs-canonical merged commit c170069 into main Jan 17, 2025
1 check passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the craft-logs branch January 17, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants