compatible(integration_test_charm): Add input that would enable metallb for integration tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
paulomach
reviewed
Oct 18, 2024
shayancanonical
changed the title
paulomach
approved these changes
Nov 26, 2024
taurus-forever
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM, but jq is not necessary here.
@carlcsaposs-canonical please review after your vacation.
dragomirp
approved these changes
Nov 26, 2024
shayancanonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Nov 27, 2024
…ues false (clusterip), nodeport and loadbalancer (#328) ## Prerequisite Need to merge canonical/data-platform-workflows#244 for metallb support in CI ## Issue We have outlined the approach to expose our K8s charms externally in DA122 Summary: - we will avoid using `external-node-connectivity` provided in data_interfaces in K8s charms - instead, we will provide a new config option `expose-external` with values `false` (for clusterip svc), `nodeport` (for nodeport svc) and `loadbalancer` (for loadbalancer svc) - we will asynchronously update the endpoints in relation databags (data_interfaces) when we are able to connect to router with the created svc using a socket ## Solution Implement the contents of the spec ## Testing - tested locally using metallb - testing on EKS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need metallb enabled for integration tests where we are creating
loadbalancertype service in canonical/mysql-router-k8s-operator#328Add ability to enable metallb