Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Install python3-pip with --no-install-recommends #187

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

carlcsaposs-canonical
Copy link
Contributor

python3-pip recommends build-essential, which is a relatively large package we don't need

python3-pip recommends build-essential, which is a relatively large package we don't need
@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Jun 11, 2024

tested on canonical/pgbouncer-operator#246

Copy link
Contributor

@shayancanonical shayancanonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt this change affect more packages than just the build-essential package?

@carlcsaposs-canonical
Copy link
Contributor Author

wouldnt this change affect more packages than just the build-essential package?

python3-venv doesn't recommend any packages
python3-pip recommends build-essential and python3-dev https://packages.ubuntu.com/jammy/python3-pip, which will no longer be installed (which is what we want—we only want python3-pip for pipx)

Copy link

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give it a try (as a process of speedup our CI/CD).

@carlcsaposs-canonical carlcsaposs-canonical merged commit 9e51d37 into main Jun 11, 2024
2 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the no-install-recommends branch June 11, 2024 14:42
carlcsaposs-canonical referenced this pull request in canonical/mysql-router-k8s-operator Jun 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[allure-pytest-collection-report](https://togithub.com/canonical/data-platform-workflows)
| integration | major | `v13.3.4` -> `v16.2.0` |
|
[canonical/data-platform-workflows](https://togithub.com/canonical/data-platform-workflows)
| action | major | `v13.3.4` -> `v16.2.0` |
|
[pytest-operator-cache](https://togithub.com/canonical/data-platform-workflows)
| integration | major | `v13.3.4` -> `v16.2.0` |
|
[pytest-operator-groups](https://togithub.com/canonical/data-platform-workflows)
| integration | major | `v13.3.4` -> `v16.2.0` |

---

### Release Notes

<details>
<summary>canonical/data-platform-workflows
(allure-pytest-collection-report)</summary>

###
[`v16.2.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.2.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.1.0...v16.2.0)

##### What's Changed

- compatible(build_charm.yaml): Add GitHub auth to avoid ccc rate limit
by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/202](https://togithub.com/canonical/data-platform-workflows/pull/202)

**Full Changelog**:
canonical/data-platform-workflows@v16.1.0...v16.2.0

##### Migration instructions

If you have a build wrapper in tox.ini, add `GH_TOKEN` to `pass_env`

```ini
[testenv:build-{production,dev,wrapper}]

##### Wrap `charmcraft pack`
pass_env =
    CI
    GH_TOKEN
```

Example:
[https://github.com/canonical/pgbouncer-k8s-operator/pull/322](https://togithub.com/canonical/pgbouncer-k8s-operator/pull/322)

###
[`v16.1.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.1.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.0.1...v16.1.0)

##### What's Changed

- compatible(integration_test_charm.yaml): Grant full SSH access on
Azure runners by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/200](https://togithub.com/canonical/data-platform-workflows/pull/200)

**Full Changelog**:
canonical/data-platform-workflows@v16.0.1...v16.1.0

###
[`v16.0.1`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.0.1)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.0.0...v16.0.1)

##### What's Changed

- patch(integration_test_charm.yaml): Decrease bootstrap timeout by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/199](https://togithub.com/canonical/data-platform-workflows/pull/199)

**Full Changelog**:
canonical/data-platform-workflows@v16.0.0...v16.0.1

###
[`v16.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.0.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v15.0.0...v16.0.0)

##### What's Changed

- breaking(release_charm.yaml): Upload OCI resources from GHCR directly
by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/198](https://togithub.com/canonical/data-platform-workflows/pull/198)

**Full Changelog**:
canonical/data-platform-workflows@v15...v16.0.0

###
[`v15.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v15.0.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v14.1.0...v15.0.0)

##### What's Changed

- breaking(integration_test_charm.yaml): Run arm64 tests on all events
by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/196](https://togithub.com/canonical/data-platform-workflows/pull/196)

**Full Changelog**:
canonical/data-platform-workflows@v14...v15.0.0

###
[`v14.1.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v14.1.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v14.0.0...v14.1.0)

##### What's Changed

- compatible(integration_test_charm.yaml): Switch arm64 to Azure-hosted
runners by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/192](https://togithub.com/canonical/data-platform-workflows/pull/192)

**Full Changelog**:
canonical/data-platform-workflows@v14.0.0...v14.1.0

###
[`v14.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v14.0.0)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.7...v14.0.0)

##### What's Changed

- breaking(integration_test_charm.yaml): Only run arm64 tests on
`schedule` by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/188](https://togithub.com/canonical/data-platform-workflows/pull/188)

**Full Changelog**:
canonical/data-platform-workflows@v13...v14.0.0

###
[`v13.3.7`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.7)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.6...v13.3.7)

##### What's Changed

- patch(\_sync_docs.yaml): Updated secret keys in usage docs by
[@&#8203;a-velasco](https://togithub.com/a-velasco) in
[https://github.com/canonical/data-platform-workflows/pull/189](https://togithub.com/canonical/data-platform-workflows/pull/189)

**Full Changelog**:
canonical/data-platform-workflows@v13.3.6...v13.3.7

###
[`v13.3.6`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.6)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.5...v13.3.6)

##### What's Changed

- patch: Install python3-pip with `--no-install-recommends` by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/187](https://togithub.com/canonical/data-platform-workflows/pull/187)

**Full Changelog**:
canonical/data-platform-workflows@v13.3.5...v13.3.6

###
[`v13.3.5`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.5)

[Compare
Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.4...v13.3.5)

##### What's Changed

- patch(integration_test_charm.yaml): Add missing link to Allure usage
docs by
[@&#8203;carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical)
in
[https://github.com/canonical/data-platform-workflows/pull/184](https://togithub.com/canonical/data-platform-workflows/pull/184)

**Full Changelog**:
canonical/data-platform-workflows@v13.3.4...v13.3.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 1am and before 3am every
weekday" in timezone Etc/UTC, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/canonical/mysql-router-k8s-operator).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Carl Csaposs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants